-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(executor): Generic precompile overrides #340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
force-pushed
the
cl/executor-builder
branch
from
June 28, 2024 16:39
c9bde10
to
5c1f7b8
Compare
clabby
force-pushed
the
cl/exec-precompile-overrides
branch
from
June 28, 2024 16:39
7294773
to
80b4c10
Compare
refcell
approved these changes
Jun 28, 2024
clabby
force-pushed
the
cl/executor-builder
branch
from
June 28, 2024 17:30
5c1f7b8
to
4b2ab79
Compare
clabby
force-pushed
the
cl/exec-precompile-overrides
branch
from
June 28, 2024 17:30
80b4c10
to
1c89f38
Compare
clabby
force-pushed
the
cl/executor-builder
branch
from
June 28, 2024 17:32
4b2ab79
to
c609dd1
Compare
clabby
force-pushed
the
cl/exec-precompile-overrides
branch
from
June 28, 2024 17:32
1c89f38
to
9816543
Compare
clabby
force-pushed
the
cl/executor-builder
branch
from
June 28, 2024 17:34
c609dd1
to
a080502
Compare
clabby
force-pushed
the
cl/exec-precompile-overrides
branch
from
June 28, 2024 17:35
9816543
to
f99a083
Compare
clabby
force-pushed
the
cl/executor-builder
branch
from
June 28, 2024 17:40
a080502
to
fe21f5a
Compare
clabby
force-pushed
the
cl/exec-precompile-overrides
branch
from
June 28, 2024 17:40
f99a083
to
753c31d
Compare
## Overview Adds a generic route for overriding precompiles in the `StatelessL2BlockExecutor`. This allows for different consumers to override the various precompiles in a way that suits their own needs.
clabby
force-pushed
the
cl/exec-precompile-overrides
branch
from
June 28, 2024 17:59
753c31d
to
e221133
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a generic route for overriding precompiles in the
StatelessL2BlockExecutor
. This allows for different consumers to override the various precompiles in a way that suits their own needs.